Re: [PATCH v3] advice: use global config for default branch name

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 9, 2026, 21:21 UTC
Message-ID: <xmqqecf2p1dd.fsf@gitster.g>
In-Reply-To: <20260909202718.GA183838@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I had somehow hoped we could reuse the existing CONFIG_SCOPE enum
> without having to redeclare it ourselves. But there are a lot more
> scopes than these three! On the other hand, I think it would be possible
> to use config_scope_name() to convert them into options.

I had the same thought, and do not have strong opinion myself either way.

For everything else you suggested in your review, I think we would want a hopefully small and final reroll.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.