Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

From: Vsevolod Myalitsin <ub4nal@mail.ru>
Date: Sep 17, 2026, 14:03 UTC
Message-ID: <20260917140350.44760-1-ub4nal@mail.ru>
In-Reply-To: <xmqq33vb4hma.fsf@gitster.g>

Junio C Hamano writes:

> So to conclude the topic, we would only need this?

Yes, I think this is indeed where we were heading.

However, during the discussion I really liked the idea of passing a pointer to the "advice_setting" to "vadvise()" instead of passing its individual fields. It seems like a cleaner interface, even though it is not directly related to this fix.

Would it make sense to submit that change as a separate patch?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.