Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism
- From
Jeff King <peff@peff.net>
- Date
- Sep 10, 2026, 19:05 UTC
- Message-ID
- <20260910190513.GB903701@coredump.intra.peff.net>
- In-Reply-To
- <20260910175416.115280-1-ub4nal@mail.ru>
On Thu, Sep 10, 2026 at 08:54:15PM +0300, Vsevolod Myalitsin wrote:
Show 11 quoted lines
> > I'm really not sure why anybody would use those other flags, though (or > > even --system, for that matter). After reading the thread again, I get > > why we want "--global" for advice that only affects new repository > > creation (like defaultBranchName), since otherwise it could never have > > any effect. But why would you ever want --system? > > I initially looked at Junio's suggestion and, based on his experience, > didn't argue with it, and then I didn't come back to that message. I > think the patch should contain not + enum config_scope scope_hint; but > + bool is_global_hint;, since I myself can't find any scenarios where > advice should be disabled at the system level.
Yeah, it feels like handling arbitrary scopes is introducing all of these extra questions. But all we really need is that original bool you had. I think there's some YAGNI principle here, too. Later if somebody comes along and really wants to advise the user to use "git config --system", they can do the bool-to-scope conversion then. I'd be surprised if that happens.
-Peff