Re: [PATCH v2 00/18] Consolidate reachability logic

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 20, 2018, 22:45 UTC
Message-ID: <xmqqsh4d8r21.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180720163227.105950-1-dstolee@microsoft.com>

Derrick Stolee <dstolee@microsoft.com> writes:

Show 10 quoted lines

> There are many places in Git that use a commit walk to determine
> reachability between commits and/or refs. A lot of this logic is
> duplicated.
>
> I wanted to achieve the following:
>
> Consolidate several different commit walks into one file
> Reduce duplicate reachability logic
> Increase testability (correctness and performance)
> Improve performance of reachability queries

All of these are good goals to shoot at.

> This series is based on jt/commit-graph-per-object-store

As such, it has some interactions with another topic [*1*] that is based on the same, but my trial merge seems to suggest that the interactions are minimum and do not pose a serious problem.

Will push out as part of the next integration run, as I've already pushed out today's.

Thanks.

[Footnote]

*1* ds/commit-graph-with-grafts topic that is in 'pu', slated to go
    'next' soonish.