Re: [PATCH v2 00/18] Consolidate reachability logic

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 20, 2018, 17:41 UTC
Message-ID: <CACsJy8CTPtxLsSoNO8xynHGoPqQ3k6N4mSykWTQ9Ceap3yV1hw@mail.gmail.com>
In-Reply-To: <20180720163227.105950-1-dstolee@microsoft.com>

On Fri, Jul 20, 2018 at 6:35 PM Derrick Stolee <dstolee@microsoft.com> wrote:

Show 8 quoted lines

>
> There are many places in Git that use a commit walk to determine
> reachability between commits and/or refs. A lot of this logic is
> duplicated.
>
> I wanted to achieve the following:
>
> Consolidate several different commit walks into one file

I'm surprised get_shallow_commits() in shallow.c didn't make the cut. It's no problem though if you already considered it and decided it was better left alone.

> Reduce duplicate reachability logic
> Increase testability (correctness and performance)
> Improve performance of reachability queries

What's your recommendation on adding new commit reachability code? I might have to add one to fix prune_shallow() if I don't find anything fit. I guess the code should go to commit-reach.c too?

-- 
Duy