Re: [PATCH 02/16] commit-reach: move ref_newer from remote.c

From: Stefan Beller <sbeller@google.com>
Date: Jul 16, 2018, 19:10 UTC
Message-ID: <CAGZ79kZh42em1mQ+LQuzN8UTqY2MCutrS8eXAh-FvzEBVGcmGg@mail.gmail.com>
In-Reply-To: <7a6d1cbe12efa0a452a977f1f6bb8c618421040b.1531746010.git.gitgitgadget@gmail.com>

On Mon, Jul 16, 2018 at 6:00 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:

>
> From: Derrick Stolee <dstolee@microsoft.com>
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>

Another verbatim move! (I'll just re-iterate that the --color-moved option is very helpful in these reviews)

Thanks, Stefan

Show 7 quoted lines

> +++ b/commit-reach.h
> @@ -38,4 +38,6 @@ struct commit_list *reduce_heads(struct commit_list *heads);
>   */
>  void reduce_heads_replace(struct commit_list **heads);
>
> +int ref_newer(const struct object_id *new_oid, const struct object_id *old_oid);
> +

Bonus points for docs on ref_newer!

Show 8 quoted lines

> +++ b/http-push.c
> @@ -14,6 +14,7 @@
>  #include "argv-array.h"
>  #include "packfile.h"
>  #include "object-store.h"
> +#include "commit-reach.h"
>
>

Double new line here? I missed that in p1, it would be nice if you could fix that up.