Re: [PATCH v2 00/18] Consolidate reachability logic

From: Derrick Stolee <stolee@gmail.com>
Date: Jul 20, 2018, 17:15 UTC
Message-ID: <833dea7f-b6dd-b3dd-6282-c0a5f939ecca@gmail.com>
In-Reply-To: <CAGZ79kY28vcs5TN9GtKd439vaTt38Qtwv8Lw0zanDaR1OmsTLg@mail.gmail.com>

On 7/20/2018 1:10 PM, Stefan Beller wrote:

Show 7 quoted lines

> Hi Derrick,
>
>> V2 Update: The biggest material change in this version is that we drop the
>> method declarations from commit.h, which requires adding a lot of references
>> to commit-reach.h across the codebase. This change is in a commit on its own.
>> In addition, we have the following smaller changes:
> Is there a remote available to get this series from?

Sure! It's on my fork [1]

[1] https://github.com/derrickstolee/git/tree/reach/refactor

Show 16 quoted lines

>> * Use 'unsigned int' for the flag variables.
>>
>> * Properly align the here-doc test input data.
>>
>> * Use single rev-parse commands in test output, and pipe the OIDs through 'sort'
>>
>> * Check output of parse_commit()
>>
>> * Update flag documentation in object.h
>>
>> * Add tests for commit_contains() including both algorithms.
>>
>> * Reduce size of "mixed-mode" commit-graph to ensure we start commit walks
>>    'above' the graph and then walk into the commits with generation numbers.
> A range diff would be nice (though I can just look at all patches again
> even if it takes longer).

I can send a diff. It's a bit big because of the indenting changes.

> I notice this is not sent via the GGG, but via git send-email?

GGG can do version updates, but is currently having trouble when the branch has conflicts with the target [2]. We will address this issue next week, but I wanted to get this version out. Thank you for your patience as we work out the kinks.

[2] https://github.com/gitgitgadget/gitgitgadget/issues/25

Thanks,

-Stolee