git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] range-diff: update stale summary of --no-dual-color

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 23, 2018, 21:48 UTC
Message-ID
<xmqqsh34hhzf.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<87pny8wz6z.fsf@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
Show 20 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> [...]
>
>>>> -			    N_("color both diff and diff-between-diffs")),
>>>> +			    N_("restrict coloring to outer diff markers")),
>>>
>>> How about "use simple diff colors" instead?
>
> That's certainly better than the one above, and I also prefer it to
> "color only based on the diff-between-diffs" in v2.
>
>> I am wondering if it makes sense to remove the option altogether.
>> I've been trying to view the comparison of the same ranges in both
>> styles for the past few days, and I never found a reason to choose
>> "no dual color" option myself.
>
> But I like this suggestion even better.

That wasn't even a suggestion. I just did not see the point of the optional behaviour myself, and was soliciting concrete examples where the --no-dual mode would help.

Previous: Kyle MeyerNext: Johannes Schindelin
Message 19 of 20 in “range-diff: update stale summary of --no-dual-color”
  1. range-diff: update stale summary of --no-dual-colorKyle Meyer, Aug 23, 2018
  2. Jonathan NiederAug 23, 2018
  3. Kyle MeyerAug 23, 2018
  4. Jonathan NiederAug 23, 2018
  5. Kyle MeyerAug 23, 2018
  6. Jonathan NiederAug 23, 2018
  7. range-diff: update stale summary of --no-dual-colorKyle Meyer, Aug 23, 2018
  8. Jonathan NiederAug 23, 2018
  9. range-diff: update stale summary of --no-dual-colorKyle Meyer, Aug 23, 2018
  10. Jonathan NiederAug 23, 2018
  11. Junio C HamanoAug 23, 2018
  12. Jonathan NiederAug 23, 2018
  13. Junio C HamanoAug 27, 2018
  14. Johannes SchindelinAug 23, 2018
  15. Jonathan NiederAug 23, 2018
  16. Johannes SchindelinAug 23, 2018
  17. Junio C HamanoAug 23, 2018
  18. Kyle MeyerAug 23, 2018
  19. Junio C HamanoAug 23, 2018
  20. Johannes SchindelinAug 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.