git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] range-diff: update stale summary of --no-dual-color

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 23, 2018, 21:10 UTC
Message-ID
<20180823211028.GA99542@aiede.svl.corp.google.com>
In-Reply-To
<20180823120026.32127-1-kyle@kyleam.com>
Kyle Meyer wrote:
>  		OPT_BOOL(0, "no-dual-color", &simple_color,
> -			    N_("color both diff and diff-between-diffs")),
> +			    N_("color only based on the diff-between-diffs")),
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Dscho's suggestion "use simple diff colors" also sounds fine to me (probably even better).

Thanks, Jonathan

Previous: Kyle MeyerNext: Kyle Meyer
Message 8 of 20 in “range-diff: update stale summary of --no-dual-color”
  1. range-diff: update stale summary of --no-dual-colorKyle Meyer, Aug 23, 2018
  2. Jonathan NiederAug 23, 2018
  3. Kyle MeyerAug 23, 2018
  4. Jonathan NiederAug 23, 2018
  5. Kyle MeyerAug 23, 2018
  6. Jonathan NiederAug 23, 2018
  7. range-diff: update stale summary of --no-dual-colorKyle Meyer, Aug 23, 2018
  8. Jonathan NiederAug 23, 2018
  9. range-diff: update stale summary of --no-dual-colorKyle Meyer, Aug 23, 2018
  10. Jonathan NiederAug 23, 2018
  11. Junio C HamanoAug 23, 2018
  12. Jonathan NiederAug 23, 2018
  13. Junio C HamanoAug 27, 2018
  14. Johannes SchindelinAug 23, 2018
  15. Jonathan NiederAug 23, 2018
  16. Johannes SchindelinAug 23, 2018
  17. Junio C HamanoAug 23, 2018
  18. Kyle MeyerAug 23, 2018
  19. Junio C HamanoAug 23, 2018
  20. Johannes SchindelinAug 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.