Re: [PATCH] range-diff: update stale summary of --no-dual-color

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 23, 2018, 21:12 UTC
Message-ID: <20180823211214.GB99542@aiede.svl.corp.google.com>
In-Reply-To: <nycvar.QRO.7.76.6.1808231629540.73@tvgsbejvaqbjf.bet>

Hi,

Johannes Schindelin wrote:

> On Wed, 22 Aug 2018, Jonathan Nieder wrote:

Show 12 quoted lines

>>  		OPT_INTEGER(0, "creation-factor", &creation_factor,
>>  			    N_("Percentage by which creation is weighted")),
>> -		OPT_BOOL(0, "no-dual-color", &simple_color,
>> -			    N_("color both diff and diff-between-diffs")),
>> +		OPT_BOOL(0, "dual-color", &dual_color,
>> +			    N_("color both diff and diff-between-diffs (default)")),
>
> There is one very good reason *not* to do that. And that reason is the
> output of `git range-diff -h`. If anybody read that the option
> `--dual-color` exists, they are prone to believe that the default is *not*
> dual color. In contrast, when reading `--no-dual-color`, it is clear that
> dual color mode is the default.

The whole patch is about "git range-diff -h" output, and of course I tested it. Did you see the "(default)" part of the string in the patch?

That said, the conversation continued and I agree with the conclusion it led to (which is better than the patch you're replying to).

Thanks, Jonathan