Re: [PATCH] range-diff: update stale summary of --no-dual-color

From: Kyle Meyer <kyle@kyleam.com>
Date: Aug 23, 2018, 21:27 UTC
Message-ID: <87pny8wz6z.fsf@kyleam.com>
In-Reply-To: <xmqq1saoixxs.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

[...]

>>> -			    N_("color both diff and diff-between-diffs")),
>>> +			    N_("restrict coloring to outer diff markers")),
>>
>> How about "use simple diff colors" instead?

That's certainly better than the one above, and I also prefer it to "color only based on the diff-between-diffs" in v2.

> I am wondering if it makes sense to remove the option altogether.
> I've been trying to view the comparison of the same ranges in both
> styles for the past few days, and I never found a reason to choose
> "no dual color" option myself.

But I like this suggestion even better.