Re: [PATCH] range-diff: update stale summary of --no-dual-color

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 23, 2018, 02:47 UTC
Message-ID: <20180823024719.GG92374@aiede.svl.corp.google.com>
In-Reply-To: <20180823023955.12980-1-kyle@kyleam.com>

Hi,

Kyle Meyer wrote:

Show 9 quoted lines

> 275267937b (range-diff: make dual-color the default mode, 2018-08-13)
> replaced --dual-color with --no-dual-color but left the option's
> summary untouched.  Rewrite the summary to describe --no-dual-color
> rather than dual-color.
>
> Signed-off-by: Kyle Meyer <kyle@kyleam.com>
> ---
>  builtin/range-diff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, good catch!

Show 10 quoted lines

> diff --git a/builtin/range-diff.c b/builtin/range-diff.c
> index f52d45d9d6..7dc90a5ec3 100644
> --- a/builtin/range-diff.c
> +++ b/builtin/range-diff.c
> @@ -25,7 +25,7 @@ int cmd_range_diff(int argc, const char **argv, const char *prefix)
>  		OPT_INTEGER(0, "creation-factor", &creation_factor,
>  			    N_("Percentage by which creation is weighted")),
>  		OPT_BOOL(0, "no-dual-color", &simple_color,
> -			    N_("color both diff and diff-between-diffs")),
> +			    N_("restrict coloring to outer diff markers")),

What is an outer diff marker?

Thanks, Jonathan