Re: [PATCH] Poison gettext with the Ook language
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 22, 2018, 23:04 UTC
- Message-ID
- <xmqqsh0xtwgb.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <878t2pd6yu.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 8 quoted lines
> So I think the only reason to keep it compile-time is performance, but I > don't think that matters. It's not like we're printing gigabytes of _() > formatted output. Everything where formatting matters is plumbing which > doesn't use this API. These messages are always for human consumption. > > So shouldn't we just drop this notion of GETTEXT_POISON at compile-time > entirely, and make GIT_GETTEXT_POISON=<boolean> a test flag that all > builds of git are aware of? I think so.
Haven't thought things through, but that sounds like a good thing to aim for. Keep the ideas coming...