From: Junio C Hamano Date: Mon, 22 Oct 2018 23:04:20 GMT Subject: Re: [PATCH] Poison gettext with the Ook language Message-ID: In-Reply-To: <878t2pd6yu.fsf@evledraar.gmail.com> Ævar Arnfjörð Bjarmason writes: > So I think the only reason to keep it compile-time is performance, but I > don't think that matters. It's not like we're printing gigabytes of _() > formatted output. Everything where formatting matters is plumbing which > doesn't use this API. These messages are always for human consumption. > > So shouldn't we just drop this notion of GETTEXT_POISON at compile-time > entirely, and make GIT_GETTEXT_POISON= a test flag that all > builds of git are aware of? I think so. Haven't thought things through, but that sounds like a good thing to aim for. Keep the ideas coming...