Re: [PATCH] Poison gettext with the Ook language
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 25, 2018, 03:52 UTC
- Message-ID
- <xmqqh8halm20.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8Dex3VYEXmvRZv5_ot1-cwjJtir=kvupzKe7-Z2qPZw+Q@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 9 quoted lines
> The person who writes
>
> printf(_("%s"), getenv("foo"));
>
> may not go through the same thought process as with complexFunction().
> If _() calls getenv(), because you the order of parameter evaluation
> is unspecified, you cannot be sure if getenv("foo") will be called
> before or after the one inside _(). One of them may screw up the
> other.Yup, sometimes we've been sloppy but we should strive to mimick efforts like f4ef5173 ("determine_author_info(): copy getenv output", 2014-08-27).