Re: [PATCH v3] i18n: make GETTEXT_POISON a runtime option

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 8, 2018, 19:12 UTC
Message-ID: <CAPig+cQR++wfWLrODNOioTu=FuLBKWX=P74kaS8X92Nrp6h_pA@mail.gmail.com>
In-Reply-To: <xmqqpnvg8d5z.fsf@gitster-ct.c.googlers.com>

On Wed, Nov 7, 2018 at 10:24 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Makefile: ease dynamic-gettext-poison transition
>
> Earlier we made the entire build to fail when GETTEXT_POISON=Yes is
> given to make, to notify those who did not notice that text poisoning
> is now a runtime behaviour.
>
> It turns out that this too irritating for those who need to build

s/too/is &/

Show 11 quoted lines

> and test different versions of Git that cross the boundary between
> history with and without this topic to switch between two
> environment variables.  Demote the error to a warning, so that you
> can say something like
>
>         make GETTEXT_POISON=Yes GIT_TEST_GETTEXT_POISON test
>
> during the transition period, without having to worry about whether
> exact version you are testing has or does not have this topic.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>