Re: [PATCH] Poison gettext with the Ook language

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2018, 06:55 UTC
Message-ID: <xmqqftwrc20q.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181025062037.GC11460@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> I.e., could we mostly ignore this problem as not applying to most modern
> systems? And if there is such a system, give it a fallback like:
>
>   /*
>    * For systems that use a single buffer for getenv(), this hacks
>    * around it by giving it _four_ buffers. That's just punting on
>    * the problem, but it at least gives enough breathing room for
>    * the caller to do something sane like use non-trivial functions
>    * to copy the string. It still does nothing for threading, but
>    * hopefully such systems don't support pthreads in the first place. ;)
>    */

Tempting.

> I dunno. Maybe I am being overly optimistic. But I strongly suspect we
> have such bugs already in our code base, and nobody has run into them

Yeah, I tend to agree that I would not be surprised at all if we have many such "bugs" that triggers for nobody on modern platforms.