git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3701: two subtests are fixed

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 16, 2022, 16:50 UTC
Message-ID
<xmqqsfo4v9gs.fsf@gitster.g>
In-Reply-To
<165537087609.19905.821171947957640468.git@grubix.eu>
Michael J Gruber <git@grubix.eu> writes:
Show 18 quoted lines
> Johannes Schindelin venit, vidit, dixit 2022-06-15 16:50:40:
>> Hi Michael,
>
> Hallo Dscho!
>
>> On Tue, 14 Jun 2022, Michael J Gruber wrote:
>> 
>> > 0527ccb1b5 ("add -i: default to the built-in implementation", 2021-11-30)
>> > switched to the implementation which fixed to subtest. Mark them as
>> > expect_success now.
>> 
>> Good catch!
>  
> I'm no list regular anymore, but still a "next+ regular". While
> experimenting with my own patch I noticed something got fixed
> unexpectedly. That goes to show that these unexpected successes
> (from expect_failure) go unnoticed too easily. I had missed this on my
> regular rebuilds.

Thanks for being a "next+ regular". They are giving us a valuable service to catch bugs and questionable design decisions before they hit the "master" branch.

> Ævar noticed this and has a better version of my patch, I think.

Yup. Eventually we will make it even impossible to opt out of the built-in variant, but until then, we'd need the conditional stuff.

Thanks.
Previous: Michael J GruberNext: Johannes Schindelin
Message 11 of 16 in “t3701: two subtests are fixed”
  1. t3701: two subtests are fixedMichael J Gruber, Jun 14, 2022
  2. add -i tests: mark "TODO" depending on GIT_TEST_ADD_I_USE_BUILTINÆvar Arnfjörð Bjarmason, Jun 14, 2022
  3. Todd ZullingerJun 15, 2022
  4. Ævar Arnfjörð BjarmasonJun 16, 2022
  5. Todd ZullingerJun 16, 2022
  6. Derrick StoleeJun 14, 2022
  7. Todd ZullingerJun 15, 2022
  8. Taylor BlauJun 15, 2022
  9. Johannes SchindelinJun 15, 2022
  10. Michael J GruberJun 16, 2022
  11. Junio C HamanoJun 16, 2022
  12. Johannes SchindelinJun 18, 2022
  13. Junio C HamanoJun 21, 2022
  14. Michael J GruberJun 22, 2022
  15. Johannes SchindelinJun 23, 2022
  16. Junio C HamanoJun 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.