Re: [PATCH] t3701: two subtests are fixed

From: Derrick Stolee <derrickstolee@github.com>
Date: Jun 14, 2022, 15:48 UTC
Message-ID: <b7d4dc9f-613c-17b6-f3e7-83cbd88a24db@github.com>
In-Reply-To: <cf6aee9acadfb666de6b24b9ed63e1a65bfc009e.1655220242.git.git@grubix.eu>

On 6/14/2022 11:26 AM, Michael J Gruber wrote:

> 0527ccb1b5 ("add -i: default to the built-in implementation", 2021-11-30)
> switched to the implementation which fixed to subtest. Mark them as
> expect_success now.

s/to subtest/two subtests/

Show 5 quoted lines

> 
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> I did check the ML but may have missed a series which contains this. (I
> only found one which tries to make the test output clearer in CI.)

The breakage vanished as of 1fc1879839 (Merge branch 'js/use-builtin-add-i', 2022-05-30). The direct change is likely 0527ccb1b5 (add -i: default to the built-in implementation, 2021-11-30), but that commit actually fails the tests, it seems. Something about a parallel topic must have made it work at the merge point.

Patch looks good. Thanks!

-Stolee