Re: [PATCH] t3701: two subtests are fixed
- From
Michael J Gruber <git@grubix.eu>
- Date
- Jun 22, 2022, 08:24 UTC
- Message-ID
- <165588628205.6252.637148192313375325.git@grubix.eu>
- In-Reply-To
- <xmqq8rpqja0v.fsf@gitster.g>
Junio C Hamano venit, vidit, dixit 2022-06-21 17:45:04:
Show 12 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> in config.mak. Nothing else strikes me as potentially relevant. > >> > >> Ævar noticed this and has a better version of my patch, I think. > > > > So you did not find it utterly rude and presumptuous that somebody sent a > > new iteration of your patch without even so much as consulting with you > > whether you're okay with this? I salute your forbearance, then. > > I had an impression that these (wasn't there another one) were > independent discoveries and patching that happened at the same time.
Yes, while it looked funny at first, Ævar explained it well. So, everything is fine for me. Besides, we're no strangers to each other ;)
As for the question which version covers the expectations best: I'm lacking the necessary overview of the expectations (which implementation to check by default, in CI etc.) which is why I won't chime in on that.