git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3701: two subtests are fixed

From
Todd Zullinger <tmz@pobox.com>
Date
Jun 15, 2022, 01:25 UTC
Message-ID
<Yqk1GCPkfauGHQQB@pobox.com>
In-Reply-To
<cf6aee9acadfb666de6b24b9ed63e1a65bfc009e.1655220242.git.git@grubix.eu>
Michael J Gruber wrote:
Show 8 quoted lines
> 0527ccb1b5 ("add -i: default to the built-in implementation", 2021-11-30)
> switched to the implementation which fixed to subtest. Mark them as
> expect_success now.
> 
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> I did check the ML but may have missed a series which contains this. (I
> only found one which tries to make the test output clearer in CI.)

I sent a patch (<20220614185218.1091413-1-tmz@pobox.com>) as well. I mentioned the commits which added these tests, but didn't call out 0527ccb1b5 (add -i: default to the built-in implementation, 2021-11-30) explicitly, which is a good addition.

I'm just happy to see the builtin `add -i` as the default.
Show 25 quoted lines
>  t/t3701-add-interactive.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
> index 94537a6b40..9a06638704 100755
> --- a/t/t3701-add-interactive.sh
> +++ b/t/t3701-add-interactive.sh
> @@ -538,7 +538,7 @@ test_expect_success 'split hunk "add -p (edit)"' '
>  	! grep "^+15" actual
>  '
>  
> -test_expect_failure 'split hunk "add -p (no, yes, edit)"' '
> +test_expect_success 'split hunk "add -p (no, yes, edit)"' '
>  	test_write_lines 5 10 20 21 30 31 40 50 60 >test &&
>  	git reset &&
>  	# test sequence is s(plit), n(o), y(es), e(dit)
> @@ -562,7 +562,7 @@ test_expect_success 'split hunk with incomplete line at end' '
>  	test_must_fail git grep --cached before
>  '
>  
> -test_expect_failure 'edit, adding lines to the first hunk' '
> +test_expect_success 'edit, adding lines to the first hunk' '
>  	test_write_lines 10 11 20 30 40 50 51 60 >test &&
>  	git reset &&
>  	tr _ " " >patch <<-EOF &&
-- 
Todd
Previous: Derrick StoleeNext: Taylor Blau
Message 7 of 16 in “t3701: two subtests are fixed”
  1. t3701: two subtests are fixedMichael J Gruber, Jun 14, 2022
  2. add -i tests: mark "TODO" depending on GIT_TEST_ADD_I_USE_BUILTINÆvar Arnfjörð Bjarmason, Jun 14, 2022
  3. Todd ZullingerJun 15, 2022
  4. Ævar Arnfjörð BjarmasonJun 16, 2022
  5. Todd ZullingerJun 16, 2022
  6. Derrick StoleeJun 14, 2022
  7. Todd ZullingerJun 15, 2022
  8. Taylor BlauJun 15, 2022
  9. Johannes SchindelinJun 15, 2022
  10. Michael J GruberJun 16, 2022
  11. Junio C HamanoJun 16, 2022
  12. Johannes SchindelinJun 18, 2022
  13. Junio C HamanoJun 21, 2022
  14. Michael J GruberJun 22, 2022
  15. Johannes SchindelinJun 23, 2022
  16. Junio C HamanoJun 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.