git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3701: two subtests are fixed

From
Taylor Blau <me@ttaylorr.com>
Date
Jun 15, 2022, 01:55 UTC
Message-ID
<Yqk7/HXsrqYK/2QR@nand.local>
In-Reply-To
<cf6aee9acadfb666de6b24b9ed63e1a65bfc009e.1655220242.git.git@grubix.eu>
On Tue, Jun 14, 2022 at 05:26:33PM +0200, Michael J Gruber wrote:
> 0527ccb1b5 ("add -i: default to the built-in implementation", 2021-11-30)
> switched to the implementation which fixed to subtest. Mark them as
> expect_success now.

Since v2.37.0-rc0 is the first tag to contain 0527ccb1b5, I bisected between v2.36 (when these two tests indeed failed) and the tip of master (8168d5e9c2 (Git 2.37-rc0, 2022-06-13) at the time of writing).

And I also got 0527ccb1b5, so the bisection looks good to me, and this was likely an oversight when 0527ccb1b5 was written. Thanks for putting the author on the CC list just in case there is any additional context.

Otherwise, this patch looks good to me.

Thanks, Taylor

Previous: Todd ZullingerNext: Johannes Schindelin
Message 8 of 16 in “t3701: two subtests are fixed”
  1. t3701: two subtests are fixedMichael J Gruber, Jun 14, 2022
  2. add -i tests: mark "TODO" depending on GIT_TEST_ADD_I_USE_BUILTINÆvar Arnfjörð Bjarmason, Jun 14, 2022
  3. Todd ZullingerJun 15, 2022
  4. Ævar Arnfjörð BjarmasonJun 16, 2022
  5. Todd ZullingerJun 16, 2022
  6. Derrick StoleeJun 14, 2022
  7. Todd ZullingerJun 15, 2022
  8. Taylor BlauJun 15, 2022
  9. Johannes SchindelinJun 15, 2022
  10. Michael J GruberJun 16, 2022
  11. Junio C HamanoJun 16, 2022
  12. Johannes SchindelinJun 18, 2022
  13. Junio C HamanoJun 21, 2022
  14. Michael J GruberJun 22, 2022
  15. Johannes SchindelinJun 23, 2022
  16. Junio C HamanoJun 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.