Re: [PATCH 00/10] config API: make "multi" safe, fix numerous segfaults

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2022, 20:12 UTC
Message-ID: <xmqqsfj9jaav.fsf@gitster.g>
In-Reply-To: <cover-00.10-00000000000-20221026T151328Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> I also think that part of the config API is a wart, but that we should
> go for a different solution. It's the only config function that
> doesn't return an "int" indicating whether we found the key.

Overall I saw some things to like in the series, but was not impressed by others. The _multi() thing in the earliest patch is a welcome change, giving an option to call nonbool() is a good idea (but I have doubts about the exectuion), and "does the key exist?" may be a good thing to have. Others ranged between "Meh?" to "it might be good, but why does it have to be done here now?".

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.