Re: [PATCH v2 0/9] config API: make "multi" safe, fix numerous segfaults

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 2, 2022, 00:49 UTC
Message-ID: <Y2G+qczur9eLVtk5@nand.local>
In-Reply-To: <cover-v2-0.9-00000000000-20221101T225822Z-avarab@gmail.com>

On Wed, Nov 02, 2022 at 12:05:11AM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> Ævar Arnfjörð Bjarmason (9):
>   for-each-repo tests: test bad --config keys
>   config tests: cover blind spots in git_die_config() tests
>   config tests: add "NULL" tests for *_get_value_multi()
>   versioncmp.c: refactor config reading next commit
>   config API: have *_multi() return an "int" and take a "dest"
>   for-each-repo: error on bad --config
>   config API users: test for *_get_value_multi() segfaults
>   config API: add "string" version of *_value_multi(), fix segfaults
>   for-each-repo: with bad config, don't conflate <path> and <cmd>

Thanks. I took the updated round, and will review it more closely when I have a chance to tomorrow.

Thanks, Taylor