Re: [PATCH v4 1/9] config tests: cover blind spots in git_die_config() tests

From: Glen Choo <chooglen@google.com>
Date: Feb 6, 2023, 08:31 UTC
Message-ID: <kl6l357ji4a6.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <patch-v4-1.9-4ae56cab7c7-20230202T131155Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> We need tests for this because a subsequent commit will alter the
> return value of git_config_get_value_multi(), which is used to get the
> config values in the git_die_config() function. This test coverage
> helps to build confidence in that subsequent change.

In v3, I recall having to read ahead quite far ahead in the series to understand why we needed this patch. In comparison, this is a lot clearer :)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.