Re: [PATCH v7 0/9] config API: make "multi" safe, fix segfaults, propagate "ret"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 9, 2023, 20:46 UTC
- Message-ID
- <xmqq4jqtac0z.fsf@gitster.g>
- In-Reply-To
- <kl6l8rg5hhen.fsf@chooglen-macbookpro.roam.corp.google.com>
Glen Choo <chooglen@google.com> writes:
Show 17 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> This series fixes numerous segfaults in config API users, because they >> didn't expect *_get_multi() to hand them a string_list with a NULL in >> it given config like "[a] key" (note, no "="'s). >> >> A larger general overview at v1[1], but note the API changes in >> v2[2]. Changes since v6[3]: >> >> * Glen pointed out that ejecting a commit in v6 orphaned a >> corresponding forward-reference in a commit message, fix that. > > Thanks for your patience with the rerolls :) I only spotted a minor > comment issue [1] (which I think was what originally motivated v5?). > IMO this will be mergeable once we reorder that comment. > > 1. https://lore.kernel.org/git/kl6ledpxhi3t.fsf@chooglen-macbookpro.roam.corp.google.com/
Thanks for carefully reading these patches. I agree that this round is in quite a good shape.