Re: [PATCH v5 00/10] config API: make "multi" safe, fix segfaults, propagate "ret"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 7, 2023, 17:38 UTC
Message-ID: <xmqqr0v1z87i.fsf@gitster.g>
In-Reply-To: <cover-v5-00.10-00000000000-20230207T154000Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> * Added tests for value-less at the end of a list to 2/10, per Junio's
>   request.

I do not "request" anything during my reviews, and I prefer not to see that verb. If you find what a reviewer suggests is valuable, you take it, otherwise you explain why it is better to go without what was suggested.

Show 11 quoted lines

>   As the much of the point of this series is to make that API less of
>   a special snowflake a new 6/10 instead finishes up the work of
>   having most of the rest of the API return the un-coerced "ret" from
>   the depths of the config API.
>
>   That patch is quite large by line count, but pretty trivial in
>   complexity. All of those functions are copy/pasted versions of one
>   another with very minor variations.
>
> * Updated the 8/10 commit message, which was stale from a previous
>   version of this topic.

This is now 9/10, thanks to the new 6/10 step being added, and it reads well.

Thanks, will queue.