Re: Re* [PATCH v5] describe: refresh the index when 'broken' flag is used

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 26, 2024, 17:35 UTC
Message-ID: <xmqqsewz1ua5.fsf@gitster.g>
In-Reply-To: <bbc223a3-2c82-4108-adf1-5e8518ff776e@gmail.com>

Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:

Show 5 quoted lines

> To me, this looks much better.  child_process_clear's name already
> suggests that is sort of like a destructor, so it makes sense to
> re-initialize everything here.  I even wonder why it was not that way to
> begin with.  I suppose no callers are assuming that it only clears args
> and env though?

I guess that validating that supposition is a prerequisite to declare the change as "much better" and "makes sense".

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.