Re: Re* [PATCH v5] describe: refresh the index when 'broken' flag is used

From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
Date: Jun 26, 2024, 18:07 UTC
Message-ID: <f7d0abce-b389-45ae-992a-adbc7ec10d50@gmail.com>
In-Reply-To: <xmqqsewz1ua5.fsf@gitster.g>

On 26/06/24 23:05, Junio C Hamano wrote:

Show 10 quoted lines

> Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:
> 
>> To me, this looks much better.  child_process_clear's name already
>> suggests that is sort of like a destructor, so it makes sense to
>> re-initialize everything here.  I even wonder why it was not that way to
>> begin with.  I suppose no callers are assuming that it only clears args
>> and env though?
> 
> I guess that validating that supposition is a prerequisite to
> declare the change as "much better" and "makes sense".

OK.  I found one: at the end of submodule.c:push_submodule()

	if (...) {
		...some setup...
		if (run_command(&cp))
			return 0;
		close(cp.out);
	}