From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 26 Jun 2024 17:35:46 GMT
Subject: Re: Re* [PATCH v5] describe: refresh the index when 'broken' flag is used
Message-ID: <xmqqsewz1ua5.fsf@gitster.g>
In-Reply-To: <bbc223a3-2c82-4108-adf1-5e8518ff776e@gmail.com>

Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:

> To me, this looks much better.  child_process_clear's name already
> suggests that is sort of like a destructor, so it makes sense to
> re-initialize everything here.  I even wonder why it was not that way to
> begin with.  I suppose no callers are assuming that it only clears args
> and env though?

I guess that validating that supposition is a prerequisite to
declare the change as "much better" and "makes sense".