Re: [PATCH v3] describe: refresh the index when 'broken' flag is used
- From
Abhijeet Sonar <abhijeet.nkt@gmail.com>
- Date
- Jun 26, 2024, 06:11 UTC
- Message-ID
- <751d79f1-3cb7-45bf-a276-fc4852039e09@gmail.com>
- In-Reply-To
- <xmqq34p1813n.fsf@gitster.g>
On 25/06/24 21:29, Junio C Hamano wrote:
> Why clear .args here?
I overlooked the fact that run_command already clears .args if the command exits with a zero exit code. Will fix, thank you.
Show 7 quoted lines
> I am wondering if the last part need to be more like > > ... > cp.no_stdout = 1; > if (run_command(&cp)) > child_process_clear(&cp); >
That makes sense to me, will do.
Thanks.