Re: [PATCH v4 2/6] sha1-array.h: align function arguments

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2018, 03:09 UTC
Message-ID: <xmqqr2mihors.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqvabuhouc.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> On Thu, May 10, 2018 at 12:42:59PM +0000, Ævar Arnfjörð Bjarmason wrote:
>>
>>> The arguments weren't lined up with the opening parenthesis. Fixes up
>>> code added in aae0caf19e ("sha1-array.h: align function arguments",
>>> 2018-04-30).
> ...
> But then "fixes up code added in" is not quite right, either.  It is
> what the commit should have touched but didn't ;-)

FWIW, I ended up with this description.

    The arguments weren't lined up with the opening parenthesis, after
    910650d2 ("Rename sha1_array to oid_array", 2017-03-31) renamed the
    function.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.