Re: [PATCH] pack-format.txt: more details on pack file format

From: Duy Nguyen <pclouds@gmail.com>
Date: May 8, 2018, 18:24 UTC
Message-ID: <CACsJy8AYjsLxvwCMXZ1PGu7iG=Vu5Dc7da-L-EmY+fBg_A4X8w@mail.gmail.com>
In-Reply-To: <87bmdqxb2s.fsf@evledraar.gmail.com>

On Tue, May 8, 2018 at 8:21 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 14 quoted lines

>
> On Tue, May 08 2018, Nguyễn Thái Ngọc Duy wrote:
>
>> The current document mentions OBJ_* constants without their actual
>> values. A git developer would know these are from cache.h but that's
>> not very friendly to a person who wants to read this file to implement
>> a pack file parser.
>>
>> Similarly, the deltified representation is not documented at all (the
>> "document" is basically patch-delta.c). Translate that C code in
>> English.
>
> Thanks, will drop my version from v4, although a comment for the enum in
> cache.h pointing the reader to these docs would be very useful.

True. I will add some together with the pack-format.txt update.

-- 
Duy