From: Junio C Hamano Date: Fri, 11 May 2018 03:09:11 GMT Subject: Re: [PATCH v4 2/6] sha1-array.h: align function arguments Message-ID: In-Reply-To: Junio C Hamano writes: > Jeff King writes: > >> On Thu, May 10, 2018 at 12:42:59PM +0000, Ævar Arnfjörð Bjarmason wrote: >> >>> The arguments weren't lined up with the opening parenthesis. Fixes up >>> code added in aae0caf19e ("sha1-array.h: align function arguments", >>> 2018-04-30). > ... > But then "fixes up code added in" is not quite right, either. It is > what the commit should have touched but didn't ;-) FWIW, I ended up with this description. The arguments weren't lined up with the opening parenthesis, after 910650d2 ("Rename sha1_array to oid_array", 2017-03-31) renamed the function.