Re: [PATCH] pack-format.txt: more details on pack file format
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 8, 2018, 18:21 UTC
- Message-ID
- <87bmdqxb2s.fsf@evledraar.gmail.com>
- In-Reply-To
- <20180508155627.19245-1-pclouds@gmail.com>
On Tue, May 08 2018, Nguyễn Thái Ngọc Duy wrote:
Show 8 quoted lines
> The current document mentions OBJ_* constants without their actual > values. A git developer would know these are from cache.h but that's > not very friendly to a person who wants to read this file to implement > a pack file parser. > > Similarly, the deltified representation is not documented at all (the > "document" is basically patch-delta.c). Translate that C code in > English.
Thanks, will drop my version from v4, although a comment for the enum in cache.h pointing the reader to these docs would be very useful.