Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 31, 2018, 20:16 UTC
Message-ID: <xmqqr2jj9n45.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180730230443.74416-3-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 16 quoted lines

> A use reported a submodule issue regarding strange case indentation
> issues, but it could be boiled down to the following test case:
>
>   $ git init test  && cd test
>   $ git config foo."Bar".key test
>   $ git config foo."bar".key test
>   $ tail -n 3 .git/config
>   [foo "Bar"]
>         key = test
>         key = test
>
> Sub sections are case sensitive and we have a test for correctly reading
> them. However we do not have a test for writing out config correctly with
> case sensitive subsection names, which is why this went unnoticed in
> 6ae996f2acf (git_config_set: make use of the config parser's event
> stream, 2018-04-09)

Am I correct to understand that this patch is a "FIX" for breakage introduced by that commit? The phrasing is not helping me to pick a good base to queue these patches on.

Thanks.