Re: [PATCH] config: fix case sensitive subsection names on writing

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 30, 2018, 12:49 UTC
Message-ID: <nycvar.QRO.7.76.6.1807301438440.10478@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqh8kkjg23.fsf@gitster-ct.c.googlers.com>

Hi,

On Fri, 27 Jul 2018, Junio C Hamano wrote:

> Stefan Beller <sbeller@google.com> writes:
>
> [...]

Thanks for the patch!

The only thing that was not clear to me from the patch and from the commit message was: the first part *is* case insensitive, right? How does the patch take care of that? Is it relying on `git_config_parse_key()` to do that? If so, I don't see it...

> I would still hold the judgment on "all except only this one"
> myself.  That's a bit too early in my mind.

Agreed. I seem to remember that I had a funny problem "in the reverse", where http.<url>.* is case-sensitive, but in an unexpected way: if the URL contains upper-case characters, the <url> part of the config key needs to be downcased, otherwise the setting won't be picked up.

Ciao, Dscho