Re: [PATCH 0/3] sb/config-write-fix done without robbing Peter

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2018, 19:49 UTC
Message-ID: <xmqq4lgc1rbv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180801193413.146994-1-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 12 quoted lines

>> Am I correct to understand that this patch is a "FIX" for breakage
>> introduced by that commit?  The phrasing is not helping me to pick
>> a good base to queue these patches on.
>
> Please pick 4f4d0b42bae (Merge branch 'js/empty-config-section-fix', 2018-05-08)
> as the base of this new series (am needs -3 to apply), although I developed this
> series on origin/master.
>
>> Even though I hate to rob Peter to pay Paul (or vice versa)
>
> Yeah me, too. Here is a proper fix (i.e. only pay Paul, without the robbery),
> and a documentation of the second bug that we discovered.

Thanks.

I started with this in 'config'

    [V.A]	r = one
    [v.a]	r = two

and did "git config --replace-all v.a.r 1", which resulted in

    [V.A]
    [v.a]
		r = 1

which is "correct", but defeats the "empty section is irritating" tweak that introduced the bug these patches try to fix, which is unfortunate.

But then "git config v.A.r 2" would give us

    [V.A]
    [v.a]
		r = 1
		r = 2

So this seems still broken, somewhat.