Re: [PATCH] config: fix case sensitive subsection names on writing

From: Stefan Beller <sbeller@google.com>
Date: Jul 27, 2018, 23:35 UTC
Message-ID: <CAGZ79kaVS96_K-G-_hEnRecBS843tjn7=Am0xZQjZABCdC7L0A@mail.gmail.com>
In-Reply-To: <xmqqfu04l5ns.fsf@gitster-ct.c.googlers.com>

On Fri, Jul 27, 2018 at 2:39 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

>
> Brandon Williams <bmwill@google.com> writes:
>
> > Either way you're probably going to need to be careful about how you do
> > string comparison against the different parts.
>
> Good suggestion.

The suggestion is a rabit hole and was a waste of time.

However I did some more manual testing and inspected the code with trace_printf debugging, and it turns out the strings compared are brought into the correct form already.

Show 9 quoted lines

> >> +    # v.a.r and v.A.r are not the same variable, as the middle
> >> +    # level of a three-level configuration variable name is
> >> +    # case sensitive.
>
> In other words, perhaps add
>
>         # "V.a.r" and "v.a.R" are the same variable, though
>
> and corresponding test here?

I removed that section and went for a shorter, more concise expression.

patch to follow.