Re: [PATCH 02/14] trace2: create new combined trace facility
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 25, 2019, 19:13 UTC
- Message-ID
- <xmqqr2d0ft43.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190125112203.GB6702@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 7 quoted lines
>> + if (ctx->nr_open_regions > 0) {
>> + int len_indent = TR2_INDENT_LENGTH(ctx);
>> + while (len_indent > dots.len) {
>> + strbuf_addf(buf, "%s", dots.buf);
>
> Please use the much simpler are more idiomatic strbuf_addbuf()
> function instead.Ahh, contrib/coccinelle/strbuf.cocci would help ;-)