Re: [PATCH v2 14/14] trace2: t/helper/test-trace2, t0210.sh, t0211.sh, t0212.sh

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2019, 22:23 UTC
Message-ID: <xmqqd0oga0b6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <851aa8f34d7223a3d872033abf2f2a95517b3b23.1548712060.git.gitgitgadget@gmail.com>

"Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> +test_expect_success 'perf stream, return code 0' '
> +	test_when_finished "rm trace.perf actual expect" &&
> +	GIT_TR2_PERF="$(pwd)/trace.perf" && export GIT_TR2_PERF &&
> +	$TT trace2 001return 0 &&
> +	unset GIT_TR2_PERF &&

Do not do this. Stoppage in any different one of these steps would leave the state of the process in different state and affects later tests (e.g. TR2_PERF may or may not be exported).

Is $TT always "test-tool" (i.e. the binary, not a shell function)? If so, consider using a single-short export, i.e.

	GIT_TR2_PERF="..." test-tool trace2 001return 0 &&