From: Junio C Hamano Date: Fri, 25 Jan 2019 19:13:32 GMT Subject: Re: [PATCH 02/14] trace2: create new combined trace facility Message-ID: In-Reply-To: <20190125112203.GB6702@szeder.dev> SZEDER Gábor writes: >> + if (ctx->nr_open_regions > 0) { >> + int len_indent = TR2_INDENT_LENGTH(ctx); >> + while (len_indent > dots.len) { >> + strbuf_addf(buf, "%s", dots.buf); > > Please use the much simpler are more idiomatic strbuf_addbuf() > function instead. Ahh, contrib/coccinelle/strbuf.cocci would help ;-)