Re: [PATCH 10/14] pack-objects: add trace2 regions
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Jan 23, 2019, 01:19 UTC
- Message-ID
- <75ceaf05-d479-67f8-3684-c8ba948f2bda@gmail.com>
- In-Reply-To
- <1aa79cb126ec43dae1c01d3ce740d9b687d69517.1548192131.git.gitgitgadget@gmail.com>
On 1/22/2019 4:22 PM, Derrick Stolee via GitGitGadget wrote:
Show 14 quoted lines
> From: Derrick Stolee <dstolee@microsoft.com> > > When studying the performance of 'git push' we would like to know > how much time is spent at various parts of the command. One area > that could cause performance trouble is 'git pack-objects'. > > Add trace2 regions around the three main actions taken in this > command: > > 1. Enumerate objects. > 2. Prepare pack. > 3. Write pack-file. > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
We've had this patch in our private branch for a while, and is how we discovered the need for the sparse push algorithm [1]. We will use it to measure it's effectiveness as new Microsoft users onboard to the new algorithm.
Thanks,
-Stolee
[1] https://public-inbox.org/git/pull.89.v5.git.gitgitgadget@gmail.com/