Re: [PATCH 00/14] Trace2 tracing facility

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Jan 30, 2019, 18:45 UTC
Message-ID: <731e57f4-3474-9fd4-8b3e-812f648a8bed@jeffhostetler.com>
In-Reply-To: <20190125200309.GB72177@google.com>

On 1/25/2019 3:03 PM, Josh Steadmon wrote:

Show 10 quoted lines

> On 2019.01.22 13:22, Jeff Hostetler via GitGitGadget wrote:
>> This patch series contains a greatly refactored version of my original
>> Trace2 series [1] from August 2018.
>>
>> A new design doc in Documentation/technical/api-trace2.txt (in the first
>> commit) explains the relationship of Trace2 to the current tracing facility.
>> Calls to the current tracing facility have not been changed, rather new
>> trace2 calls have been added so that both continue to work in parallel for
>> the time being.
>>

...

Show 8 quoted lines

> 
> Several patches in this series have many style diffs as reported by
> clang-format. Not all the diffs actually improve readability, but many
> do. If you have clang-format installed, you can run:
> 
> git clang-format --style file --diff --extensions c,h ${commit}^ ${commit}
> 
> for each commit in the series to see what it thinks needs to be changed.

Thanks for the pointer. I'll address this in my V3 version. Yes, there were lots of complaints. Some were more noise than anything else, but there were some good ones in there.

Show 6 quoted lines

> 
> Other than that, I don't have any comments apart from what the other
> reviewers have already mentioned.
> 
> Thanks for the series!
>

Thanks, Jeff