Re: [PATCH v2 5/6] t: convert grep assertions to test_grep
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 29, 2026, 21:21 UTC
- Message-ID
- <xmqqqzlpt543.fsf@gitster.g>
- In-Reply-To
- <xmqq4iin4e1i.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Ah, of course. Michael sidesteps this mechanism by not using > "test_grep !", with > > ! grep dirty file3 && # lint-ok: file may not exist after --quit > > and if we realize that "may not exist" is actually "never exists", > then your other patch from 5 years ago would become the most > sensible fix for this line. > > It may not be a bad idea to go through "# lint-ok:" introduced by > Michael's series with finer toothed comb (there are only a handful > of them) and see if there are similar "look, the file we are > grepping in never exists with correctly running Git" gotchas.
In any case, I think SZEDER's fix to stop grepping in the file but instead insisting on its absense does make sense and it is now in 'next'. So perhaps this topic can have a small and final reroll v3 that omits change to this particular line (and possibly fix other lines that punts with "# lint-ok" if needed) and we can declare victory after that?
Thanks, all.