Re: [PATCH v2 5/6] t: convert grep assertions to test_grep
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Jul 2, 2026, 04:14 UTC
- Message-ID
- <CAC2Qwm+-r0RphATu7UiO7yLn4Phuzpjhx8NC339+DwL6q=nMDw@mail.gmail.com>
- In-Reply-To
- <xmqqqzlpt543.fsf@gitster.g>
On Mon, Jun 29, 2026 at 2:21 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> > > It may not be a bad idea to go through "# lint-ok:" introduced by > > Michael's series with finer toothed comb (there are only a handful > > of them) and see if there are similar "look, the file we are > > grepping in never exists with correctly running Git" gotchas. > > In any case, I think SZEDER's fix to stop grepping in the file but > instead insisting on its absense does make sense and it is now in > 'next'. So perhaps this topic can have a small and final reroll v3 > that omits change to this particular line (and possibly fix other > lines that punts with "# lint-ok" if needed) and we can declare > victory after that? > > Thanks, all.
Thank you, SZEDER, for the nice catch.
I will apply the suggested fix to the series locally, and go through the other #lint-ok's with a fine toothed comb as Junio suggests.
Appreciate the eyes on the series, will send a reroll soon.