Re: [PATCH 0/6] t: add lint-style.pl and convert grep to test_grep
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Jun 13, 2026, 16:28 UTC
- Message-ID
- <CAC2Qwm+-aNRa5S1UiTqXbMZi9hxE_FCOjCQ6cL2trgufktsNiQ@mail.gmail.com>
- In-Reply-To
- <xmqqldcovhnf.fsf@gitster.g>
On Mon, Jun 8, 2026 at 2:36 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> > I do not think we want an automated tool that rewrites the source > files. I was hoping that we would get a patch or two that _adds_ to > existing test-lint framework (i.e., 'test-grep' that 'test-lint' > target depends on in t/Makefile) that gives diagnosis in a similar > fashion as test-lint-shell-syntax and test-chainlint do. > > Also some existing uses of "grep" are not end-user facing and should > not be rewritten to "test_grep".
Apologies for not responding explicitly before sending a re-roll, I will do that in the future. v2 attempts to address these points as noted in the "changes" section.