Re: [PATCH v3 0/6] t: add greplint.pl and convert grep to test_grep
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Jul 5, 2026, 02:49 UTC
- Message-ID
- <CAC2QwmKvb24Rhx44aey8MuGtV5=3m++5OZwcCrMGwqvAhjdmLQ@mail.gmail.com>
- In-Reply-To
- <xmqqtsqedxmt.fsf@gitster.g>
On Sat, Jul 4, 2026 at 6:38 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> > It is not quite clear if I can follow this instruction myself, > without knowing what a "plain guarded 'grep'" is, unfortunately. Is > it different from bog-standard grep? >
I agree with you that the word "guarded" is really confusing here after reading it again. The suggestion should just be to use "plain `grep`" with no mention of a guard. Will remove it.
My original intent was something along the lines of "guarded against BUG'ing on missing file", but the wording is confusing and, worse, could encourage the anti-pattern of using grep to test for file existence.