Re: [PATCH 30/67] ref-filter: drop sprintf and strcpy calls
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> The ref-filter code comes from for-each-ref, and inherited a
> number of raw sprintf and strcpy calls. These are generally
> all safe, as we custom-size the buffers, or are formatting
> numbers into sufficiently large buffers. But we can make the
> resulting code even simpler and more obviously correct by
> using some of our helper functions.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> ref-filter.c | 70 +++++++++++++++++++-----------------------------------------
> 1 file changed, 22 insertions(+), 48 deletions(-)
The end result indeed is much easier to read. Looks good.