Re: [PATCH 57/67] receive-pack: simplify keep_arg computation

From: Jeff King <peff@peff.net>
Date: Sep 18, 2015, 18:49 UTC
Message-ID: <20150918184954.GA1589@sigill.intra.peff.net>
In-Reply-To: <CAPig+cQbVhksrS1T3tep570Rxj9KxX3HmWAYY2SzqoAg35w-EQ@mail.gmail.com>

On Fri, Sep 18, 2015 at 02:43:56PM -0400, Eric Sunshine wrote:

Show 10 quoted lines

> On Tue, Sep 15, 2015 at 12:10 PM, Jeff King <peff@peff.net> wrote:
> > To generate "--keep=receive-pack $pid on $host", we write
> > progressively into a single buffer, which requires keeping
> > track of how much we've written so far. But since the result
> > is destined to go into our argv array, we can simply use
> > argv_array_pushf.
> >
> > Unfortunately we still have to have a static buffer for the
> 
> s/static/fixed-size/ maybe?

Thanks, will change.

The term "static buffer overflow" seems stuck in my head (and you can find references via google), even though it does not make sense at all. In C terms, a stack buffer is really an "auto", but I guess "auto buffer overflow" does not have as nice a ring to it.

I agree that "fixed-size" is a lot less confusing, and corrected several such cases before sent out the series. I guess I missed one (I'll grep for others).

-Peff